Skip to content

Conversation

@fernando-torres-blip-ai
Copy link
Contributor

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [ x ] Follow the CONTRIBUTING Guide.
  • [ x ] Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • [ x ] Ensure the tests and linter pass (Run nox -s format from the repository root to format)
  • Appropriate docs were updated (if necessary)

Fixes #301 🦕

@fernando-torres-blip-ai fernando-torres-blip-ai requested a review from a team as a code owner July 12, 2025 17:54
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @fernando-torres-blip-ai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the RequestContext class by introducing a new metadata property. This addition allows consumers of the context object to easily retrieve and utilize request-specific metadata, improving the flexibility and information richness of the RequestContext for various agent execution scenarios.

Highlights

  • New Feature: Metadata Property: I've added a new metadata property to the RequestContext class. This property provides a convenient way to access any associated metadata from the underlying request parameters, returning an empty dictionary if no parameters or metadata are present.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a metadata property to the RequestContext class. I've identified two areas for improvement: enhancing the type hint for better code clarity and adding unit tests to ensure the new functionality is reliable and maintainable.

@holtskinner holtskinner force-pushed the chore-000-param-metadata branch from 6a142f8 to f7f43ba Compare July 14, 2025 16:07
@holtskinner holtskinner merged commit e781ced into a2aproject:main Jul 14, 2025
5 checks passed
holtskinner pushed a commit that referenced this pull request Jul 14, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.2.12](v0.2.11...v0.2.12)
(2025-07-14)


### Features

* add `metadata` property to `RequestContext`
([#302](#302))
([e781ced](e781ced))
* add A2ABaseModel
([#292](#292))
([24f2eb0](24f2eb0))
* add support for notification tokens in PushNotificationSender
([#266](#266))
([75aa4ed](75aa4ed))
* Update A2A types from specification 🤖
([#289](#289))
([ecb321a](ecb321a))


### Bug Fixes

* add proper a2a request body documentation to Swagger UI
([#276](#276))
([4343be9](4343be9)),
closes [#274](#274)
* Handle asyncio.cancellederror and raise to propagate back
([#293](#293))
([9d6cb68](9d6cb68))
* Improve error handling in task creation
([#294](#294))
([6412c75](6412c75))
* Resolve dependency issue with sql stores
([#303](#303))
([2126828](2126828))
* Send push notifications for message/send
([#298](#298))
([0274112](0274112))
* **server:** Improve event consumer error handling
([#282](#282))
([a5786a1](a5786a1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat]: Properly access send message param metadata in agent executor

2 participants