-
Notifications
You must be signed in to change notification settings - Fork 329
test: add test for non-blocking sendMessage #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @swapydapy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing test coverage by adding a dedicated test case for the non-blocking functionality of the sendMessage operation. The new test ensures that asynchronous message processing correctly initiates and completes tasks in the background, validating a key aspect of the system's concurrency model.
Highlights
- New Test Case for Non-Blocking SendMessage: I've added
test_on_message_send_non_blockingtotest_default_request_handler.py. This new test specifically verifies the asynchronous behavior of theon_message_sendmethod whenblockingis set toFalsein theMessageSendConfiguration. It initiates a non-blocking message send and then polls the task store to confirm the task eventually reaches acompletedstate. - Test Agent Executor: To support the new non-blocking test, I've introduced a
HelloAgentExecutorclass. This mock agent executor simulates an agent's execution flow, including creating a new task if none exists, updating its status toworking, adding an artifact, and finally marking the task ascompleted.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a test case for the non-blocking sendMessage functionality. Suggestions have been provided to improve type safety, logging, and assertion practices within the test to enhance its robustness and maintainability.
No description provided.