docs(react): update explorer README to use npx vite instead of creating package.json#1507
Open
AshikaAnand12 wants to merge 2 commits into
Open
docs(react): update explorer README to use npx vite instead of creating package.json#1507AshikaAnand12 wants to merge 2 commits into
AshikaAnand12 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the README.md for a2ui_explorer to simplify setup, build, and test instructions by replacing npm scripts with direct npx commands. Feedback on the changes points out that using 'npx vite --mode test' for running tests is incorrect as it starts the development server in test mode instead of executing the test suite, and suggests using 'npx vitest' instead.
fc5cb1f to
5cf98ef
Compare
Author
|
Hi @Ahamed009, Hi @selamw1, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating README.md for the issue : #1501
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.