Conversation
* Check link text to make sure it's exactly the URL or don't convert.
* regex tests using mocha + chai
…PI key from being exposed to users). - LRU cache to reduce quota usage. - Supports `t=`, '`start=`', `end=` query string parameters - With valid API key displays title, channel and duration information
…cess what the youtube API returns.
BenLubar
added a commit
to boomzillawtf/tdwtf
that referenced
this pull request
Jun 4, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes simplify the client handling. The API calls are all done on the server (and cached with an LRU to minimize quota usage) with graceful degradation without an API key.
Above the video, there's a link (using the user's original link) with the video title, channel title, start and end times if the user supplied them, plus the total duration of the video. Without API, it just says "Youtube video."