Skip to content

Fix short message and type not populated for junit output #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
a7ex merged 2 commits into from
Mar 17, 2025
Merged

Fix short message and type not populated for junit output #52

a7ex merged 2 commits into from
Mar 17, 2025

Conversation

@luispadron
Copy link
Collaborator

@luispadron luispadron commented Mar 17, 2025

Before

<?xml version="1.0" encoding="UTF-8"?>
<testsuites tests="15" failures="1" errors="0" time="11.643">
    <testsuite name="NonEmpty-Unit-UnitTests.xctest" tests="15" failures="1" errors="0" time="0.02">
        <testcase name="testArray()" time="0.001" classname="NonEmptyTests"/>
        <testcase name="testCollectionCount()" time="0" classname="NonEmptyTests"/>
        <testcase name="testCollectionFirstWithNonOptionalElements()" time="0" classname="NonEmptyTests"/>
        <testcase name="testCollectionFirstWithOptionalElements()" time="0" classname="NonEmptyTests"/>
        <testcase name="testCollectionLastWithNonOptionalElements()" time="0" classname="NonEmptyTests"/>
        <testcase name="testCollectionLastWithOptionalElements()" time="0" classname="NonEmptyTests"/>
        <testcase name="testCollectionSubscripts()" time="0" classname="NonEmptyTests"/>
        <testcase name="testCustomStringConvertible()" time="0" classname="NonEmptyTests"/>
        <testcase name="testDictionary()" time="0" classname="NonEmptyTests"/>
        <testcase name="testMutableCollectionSubscripts()" time="0" classname="NonEmptyTests"/>
        <testcase name="testNil()" time="0" classname="NonEmptyTests"/>
        <testcase name="testRangeReplaceableCollectionAppend()" time="0" classname="NonEmptyTests"/>
        <testcase name="testRangeReplaceableCollectionAppendSequence()" time="0" classname="NonEmptyTests"/>
        <testcase name="testSet()" time="0.001" classname="NonEmptyTests"/>
        <testcase name="testString()" time="0.014" classname="NonEmptyTests">
            <failure message="short">XCTAssertNil failed: "foo" (/Users/lpadron/Library/Developer/CoreSimulator/Devices/237D0DD7-EB1F-45EE-BB0D-A286B7A937A1/data/Code/CashFoundation/NonEmpty/UnitTests/NonEmptyTests.swift:15)</failure>
        </testcase>
    </testsuite>
</testsuites>

After

<?xml version="1.0" encoding="UTF-8"?>
<testsuites tests="15" failures="1" errors="0" time="11.643">
    <testsuite name="NonEmpty-Unit-UnitTests.xctest" tests="15" failures="1" errors="0" time="0.02">
        <testcase name="testArray()" time="0.001" classname="NonEmptyTests"/>
        <testcase name="testCollectionCount()" time="0" classname="NonEmptyTests"/>
        <testcase name="testCollectionFirstWithNonOptionalElements()" time="0" classname="NonEmptyTests"/>
        <testcase name="testCollectionFirstWithOptionalElements()" time="0" classname="NonEmptyTests"/>
        <testcase name="testCollectionLastWithNonOptionalElements()" time="0" classname="NonEmptyTests"/>
        <testcase name="testCollectionLastWithOptionalElements()" time="0" classname="NonEmptyTests"/>
        <testcase name="testCollectionSubscripts()" time="0" classname="NonEmptyTests"/>
        <testcase name="testCustomStringConvertible()" time="0" classname="NonEmptyTests"/>
        <testcase name="testDictionary()" time="0" classname="NonEmptyTests"/>
        <testcase name="testMutableCollectionSubscripts()" time="0" classname="NonEmptyTests"/>
        <testcase name="testNil()" time="0" classname="NonEmptyTests"/>
        <testcase name="testRangeReplaceableCollectionAppend()" time="0" classname="NonEmptyTests"/>
        <testcase name="testRangeReplaceableCollectionAppendSequence()" time="0" classname="NonEmptyTests"/>
        <testcase name="testSet()" time="0.001" classname="NonEmptyTests"/>
        <testcase name="testString()" time="0.014" classname="NonEmptyTests">
            <failure message="Uncategorized: NonEmptyTests.testString()" type="Uncategorized">XCTAssertNil failed: "foo" (/Users/lpadron/Library/Developer/CoreSimulator/Devices/237D0DD7-EB1F-45EE-BB0D-A286B7A937A1/data/Code/CashFoundation/NonEmpty/UnitTests/NonEmptyTests.swift:15)</failure>
        </testcase>
    </testsuite>
</testsuites>

@luispadron luispadron changed the title Fix short message not populated for junit output Fix short message and type not populated for junit output Mar 17, 2025
@luispadron luispadron requested review from a7ex and jszumski March 17, 2025 17:34
@luispadron
Copy link
Collaborator Author

luispadron commented Mar 17, 2025

Technically i think message should be the failure message (e.g. the XCTAssertNil failed ...) and the body of the failure should be stack trace or more details info but i dont know how to get that from the xcresult

@luispadron luispadron force-pushed the luis/fix-short-message-junit branch from d4093ff to b46f6c8 Compare March 17, 2025 20:46
@a7ex
Copy link
Owner

a7ex commented Mar 17, 2025

Thx for the fix, Luis!
I fixed the unit tests and will merge it.

@a7ex a7ex merged commit ea4e78a into main Mar 17, 2025
1 check passed
@jszumski jszumski deleted the luis/fix-short-message-junit branch March 18, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jszumski jszumski jszumski approved these changes

@a7ex a7ex a7ex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luispadron @a7ex @jszumski