Fix incorrect JUnit failure message for merged & repeated test case #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
approved these changes
Mar 17, 2025
…se the first global failure message for the test case instead of the one associated with the current test action.
jszumski
force-pushed
the
jszumski/fix-merged-repeated-test-messages
branch
from
80e592a to
e6097af
Compare
a7ex
approved these changes
Mar 17, 2025
Owner
a7ex
left a comment
a7ex
left a comment
There was a problem hiding this comment.
Thank you for the fix, John! Much appreciated.
I fixed the unit tests after merging Luis change and will merge it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where a merged xcresult with repeated failures would only use the first global failure message for the test case instead of the one associated with the current test action.
The new test fixture is from a unit test that fails with a random number from 1-100. Prior to this fix, all 3 entries in the JUnit output would have the same failure message ("failed - Failed with number: 51") instead of a unique one for each.