Added audio, play/pause button and audio switch, image and audio file…#13
Added audio, play/pause button and audio switch, image and audio file…#13zseiman wants to merge 3 commits intoaapomm:masterfrom
Conversation
…s as well as corresponding directories HTML =>div #mute =>audio css =>mute =>mute:hover directories =>images =>music JavaScript =>MusicSwitch function and associated commands images =>muteButton.png =>mutedButton.png audio =>bensound-scifi.mp3 text =>Credits (url to music source)
|
@zseiman thank you for this pull request! I appreciate it. Though, there are some concerns that need to be addressed before I can merge this. |
css/main.css
Outdated
|
|
||
| text-align: right; | ||
| } | ||
| #mute{ |
There was a problem hiding this comment.
@zseiman can you move this to utility.css? This is to preserve the files' semantics. I think the mute button is a "utility" and shouldn't belong in main.css. Thanks.
Also, the mute button seems to push the whole console off center. I think it would be better if the button is placed at the top left/right preferably with position: absolute.
|
For linking: fix for issue #10 |
|
Awesome! Yea, I'm happy to try to help. I'm just stoked to have an opportunity to contribute to something. Thanks for the response! |
=>index.html added audio tag with autoplay and loop attributes => +music.js added music.js containing 'musicSwitch' function =>utility.css added #mute button styling
| height: 27px; | ||
|
|
||
| text-align: right; | ||
| } |
There was a problem hiding this comment.
Whoops! Sorry about that. Have to work on my code cleanliness. This is my first attempt at contribution and I'm pretty nervous about it.
fixed bracket in main.css and indentation in music.js
3 participants
…s as well as corresponding directories
HTML
=>div #mute
=>audio
css
=>mute
=>mute:hover
directories
=>images
=>music
JavaScript
=>MusicSwitch function and associated commands
images
=>muteButton.png
=>mutedButton.png
audio
=>bensound-scifi.mp3
text
=>Credits (url to music source)
Purpose: to add background music to game along with optional on/off switch