🎨 Palette: Add accessibility attributes to button loading state#204
🎨 Palette: Add accessibility attributes to button loading state#204aarjava wants to merge 2 commits into
Conversation
💡 What: Added `aria-hidden="true"` to the `Loader2` icon and `aria-busy={isLoading}` to the root button element in `src/components/ui/button.tsx`.
🎯 Why: Prevents screen readers from announcing the decorative spinner icon and correctly communicates the button's loading state to assistive technologies.
♿ Accessibility: Improves experience for screen reader users by reducing noise and providing accurate state information.
Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
💡 What: Added `aria-hidden="true"` to the `Loader2` icon and `aria-busy={isLoading}` to the root button element in `src/components/ui/button.tsx`.
🎯 Why: Prevents screen readers from announcing the decorative spinner icon and correctly communicates the button's loading state to assistive technologies.
♿ Accessibility: Improves experience for screen reader users by reducing noise and providing accurate state information.
Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
1 participant
🎨 Palette: Add accessibility attributes to button loading state
💡 What: Added
aria-hidden="true"to theLoader2icon andaria-busy={isLoading}to the root button element insrc/components/ui/button.tsx.🎯 Why: Prevents screen readers from announcing the decorative spinner icon and correctly communicates the button's loading state to assistive technologies.
♿ Accessibility: Improves experience for screen reader users by reducing noise and providing accurate state information.
PR created automatically by Jules for task 14664259022462081917 started by @aarjava