Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-06-16 - [Keyboard Nav for Drilldown Component]
**Learning:** Added aria-current='step', <nav aria-label='Breadcrumb'> wrappers, aria-live='polite' dynamic counters, and focus-visible:ring-2 to drilldown-navigation to vastly improve keyboard accessibility and screen reader support without changing visual behavior.
**Action:** Always wrap progressive disclosure step indicators in a semantic <nav> and explicitly hide decorative icons.
22 changes: 13 additions & 9 deletions src/components/drilldown/drilldown-navigation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,25 +56,29 @@ export function DrilldownNavigation({
return (
<div className={clsx('flex flex-col', className)}>
{/* Navigation Breadcrumb */}
<div className="flex items-center gap-2 mb-4 text-sm text-neutral-400">
<nav
aria-label="Breadcrumb"
className="flex items-center gap-2 mb-4 text-sm text-neutral-400"
>
{levels.map((level, idx) => (
<div key={level.id} className="flex items-center gap-2">
<button
onClick={() => {
setCurrentLevel(idx)
onLevelChange?.(level.id)
}}
aria-current={idx === currentLevel ? 'step' : undefined}
className={clsx(
'hover:text-neutral-200 transition-colors',
'rounded-sm focus-visible:ring-2 focus-visible:ring-indigo-400 focus:outline-none hover:text-neutral-200 transition-colors',
idx === currentLevel && 'text-neutral-200 font-medium'
)}
>
{level.title}
</button>
{idx < levels.length - 1 && <ChevronRight className="size-4" />}
{idx < levels.length - 1 && <ChevronRight className="size-4" aria-hidden="true" />}
</div>
))}
</div>
</nav>

{/* Current Level Content */}
<div className="flex-1">{current.content}</div>
Expand All @@ -85,34 +89,34 @@ export function DrilldownNavigation({
onClick={handleBack}
disabled={currentLevel === 0}
className={clsx(
'flex items-center gap-2 px-4 py-2 rounded-md text-sm font-medium transition-opacity',
'flex items-center gap-2 px-4 py-2 text-sm font-medium transition-opacity rounded-sm focus-visible:ring-2 focus-visible:ring-indigo-400 focus:outline-none',
'hover:opacity-80',
currentLevel === 0
? 'opacity-50 cursor-not-allowed text-neutral-500'
: 'text-neutral-300'
)}
>
<ChevronLeft className="size-4" />
<ChevronLeft className="size-4" aria-hidden="true" />
Back
</button>

<div className="text-xs text-neutral-500">
<div className="text-xs text-neutral-500" aria-live="polite" aria-atomic="true">
Level {currentLevel + 1} of {levels.length}
</div>

<button
onClick={handleNext}
disabled={currentLevel === levels.length - 1}
className={clsx(
'flex items-center gap-2 px-4 py-2 rounded-md text-sm font-medium transition-opacity',
'flex items-center gap-2 px-4 py-2 text-sm font-medium transition-opacity rounded-sm focus-visible:ring-2 focus-visible:ring-indigo-400 focus:outline-none',
'hover:opacity-80',
currentLevel === levels.length - 1
? 'opacity-50 cursor-not-allowed text-neutral-500'
: 'text-neutral-300'
)}
>
Next
<ChevronRight className="size-4" />
<ChevronRight className="size-4" aria-hidden="true" />
</button>
</div>
</div>
Expand Down
Loading