🎨 Palette: Improve accessibility of More options button in EventAnnotations#207
🎨 Palette: Improve accessibility of More options button in EventAnnotations#207aarjava wants to merge 3 commits into
Conversation
…ions Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46caa9a58e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| className="rounded-lg p-1.5 text-[#9CA3AF] hover:bg-[#F8FAFC] hover:text-[#666666] transition-colors" | ||
| aria-label="More actions" | ||
| aria-expanded={showActionsFor === thread.id} | ||
| aria-haspopup="menu" |
There was a problem hiding this comment.
When this button is opened, the popup rendered below is still a plain motion.div containing native buttons rather than an ARIA menu with menuitems and the expected menu keyboard behavior. In the screen-reader path for this options control, aria-haspopup="menu" now advertises menu semantics that the popup does not implement; either use the existing Radix dropdown menu primitive here or omit/change this attribute until the popup has matching roles and keyboard handling.
Useful? React with 👍 / 👎.
…ions Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
…ions Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
1 participant
💡 What: Added
aria-label,aria-expanded, andaria-haspopupto the "More options" icon-only button in the EventAnnotations component, and addedaria-hidden="true"to its inner icon.🎯 Why: Improves accessibility for screen readers by announcing the button's purpose and its current expanded/collapsed state for the actions menu.
♿ Accessibility: Makes the icon-only trigger semantic and compliant with menu button patterns, preventing screen reader users from encountering an unlabeled button.
PR created automatically by Jules for task 9911832414064100094 started by @aarjava