🎨 Palette: Improve accessibility in UserPreferencesModal#210
Conversation
Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
💡 What: Added
aria-labelto the icon-only close button and upgraded the customToggleRowbutton withrole="switch",aria-checked, a descriptive label, and keyboard focus styles.🎯 Why: The custom toggle controls and icon-only close button lacked native accessibility semantics. By adding these ARIA roles and keyboard focus styles (
focus-visible:ring-2), we vastly improve the experience for screen reader users and those navigating the application via keyboard, allowing them to perceive and interact with preference settings correctly.♿ Accessibility:
aria-label="Close preferences"to<X />close button.role="switch",aria-checked, andaria-labelto theToggleRowbutton.focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-[#6C63FF] focus-visible:ring-offset-2) to theToggleRowbutton to ensure it is visible when tabbed to.PR created automatically by Jules for task 14440003833719724687 started by @aarjava