🎨 Palette: Add keyboard support and loading state to CommentsPanel#212
🎨 Palette: Add keyboard support and loading state to CommentsPanel#212aarjava wants to merge 2 commits into
Conversation
Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3aec3f17fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (e.key === 'Enter' && !loading && text.trim()) { | ||
| post() |
There was a problem hiding this comment.
When a user types a comment with an IME for languages such as Japanese or Chinese, pressing Enter often commits the current composition/candidate instead of meaning “submit”. This handler now treats every Enter as a post action, so those users can accidentally submit a partially composed comment; check the composition state, e.g. e.nativeEvent.isComposing, before calling post().
Useful? React with 👍 / 👎.
Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
1 participant
💡 What: Added keyboard submission (Enter key) and an accessible loading state (spinner) to the CommentsPanel component.
🎯 Why: Improves the commenting experience by allowing keyboard-only users to submit comments without reaching for the mouse, and provides clear visual feedback when a submission is in progress.
📸 Before/After: Visual changes involve the "Post" text swapping out for a spinning
Loader2icon when posting.♿ Accessibility: Added
aria-busy={loading}to the button, hidden the decorative spinner from screen readers witharia-hidden="true", and ensured keyboard submit capability.PR created automatically by Jules for task 7648307016404545964 started by @aarjava