Skip to content

🎨 Palette: Add accessibility attributes to Button loading state#219

Open
aarjava wants to merge 2 commits into
mainfrom
jules-6936000228781184011-ccd7a806
Open

🎨 Palette: Add accessibility attributes to Button loading state#219
aarjava wants to merge 2 commits into
mainfrom
jules-6936000228781184011-ccd7a806

Conversation

@aarjava

@aarjava aarjava commented Jun 29, 2026

Copy link
Copy Markdown
Owner

🎨 Palette: Add accessibility attributes to Button loading state

💡 What:
Added aria-busy={isLoading} to the button element and aria-hidden="true" to the decorative Loader2 spinner icon in src/components/ui/button.tsx. I also created the .Jules/palette.md file to journal this critical learning about screen reader compatibility for loading spinners.

🎯 Why:
When a button enters a loading state (e.g., waiting for an async operation), assistive technologies like screen readers need to be explicitly informed of this busy state. Without aria-busy, the user might not know the action is processing. Furthermore, purely decorative spinning icons (like Loader2 from lucide-react) can sometimes be redundantly or confusingly read out by screen readers, causing unnecessary noise.

♿ Accessibility:

  • aria-busy={isLoading} on the parent interactive element ensures screen readers correctly announce the processing state.
  • aria-hidden="true" on the Loader2 SVG prevents screen readers from reading the decorative icon.

PR created automatically by Jules for task 6936000228781184011 started by @aarjava

Added `aria-busy={isLoading}` to the button element and `aria-hidden="true"` to the decorative `Loader2` spinner icon in `src/components/ui/button.tsx`. This ensures screen readers correctly interpret the busy state without reading out the decorative loading icon. Also recorded this learning in `.Jules/palette.md`.

Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fluxlens-ai Ready Ready Preview, Comment Jun 29, 2026 10:41pm

Added `aria-busy={isLoading}` to the button element and `aria-hidden="true"` to the decorative `Loader2` spinner icon in `src/components/ui/button.tsx`. This ensures screen readers correctly interpret the busy state without reading out the decorative loading icon. Also recorded this learning in `.Jules/palette.md`.

Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant