🎨 Palette: Enable native Enter to submit on Invite Member Dialog#220
🎨 Palette: Enable native Enter to submit on Invite Member Dialog#220aarjava wants to merge 4 commits into
Conversation
🎨 Palette: Enable "Enter to confirm" on Invite Member form * I wrapped the inputs in a standard `<form>` tag. * I linked the external DialogFooter action button to the form via the HTML5 `form="..."` attribute. * I configured it to allow users to intuitively press "Enter" in the input fields to send the form without needing mouse interaction. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a598bb5588
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <form | ||
| id="invite-member-form" |
There was a problem hiding this comment.
Adding a native form here turns on browser constraint validation for the existing required and type="email" inputs. When a user submits with a blank name/email or an email that fails the browser check, the browser blocks the submit event before handleSubmit() runs, so the component no longer populates its styled FormField errors/role="alert" messages that the old click handler showed. Add noValidate to the form (while keeping onSubmit) or otherwise route invalid submissions through the existing validator.
Useful? React with 👍 / 👎.
Fix CI errors including Node.js deprecation in workflows, TS resolution for CSS modules, response status type assertions, store hygiene test artifact leaks, and ambiguous text lookups in DOM tests. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Fix CI errors including Node.js deprecation in workflows, TS resolution for CSS modules, response status type assertions, store hygiene test artifact leaks, and ambiguous text lookups in DOM tests. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Fix CI errors including Node.js deprecation in workflows, TS resolution for CSS modules, response status type assertions, store hygiene test artifact leaks, and ambiguous text lookups in DOM tests. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
1 participant
💡 What: Enabled native "Enter to submit" functionality on the
InviteMemberDialogcomponent by wrapping the inputs in a<form>and linking the submit button to it via the HTML5formattribute.🎯 Why: A common frustration in modals/dialogs acting as forms is the lack of "Enter to submit". Faux forms (wrapped in standard divs) break this implicit submission behavior. Using a native
<form>provides a semantic and robust solution over intercepting individual keydown events which could cause side effects on other elements.♿ Accessibility: Improves keyboard navigation and usability by making form submission match standard browser behavior.
PR created automatically by Jules for task 1478621497719178007 started by @aarjava