fix: use visual column instead of byte offset in get_scol() #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Great PR, thank you! Gotta get the tests passing before it can be merged though. |
ahdzib-maya
force-pushed
the
fix/visual-column-calculation
branch
2 times, most recently
from
3551c52 to
fea46c1
Compare
Contributor
Author
Ready to merge @aaronik |
Owner
|
Excellent - is there any way you can add a test that covers this? It should be relatively easy, just adding a go fixture file that covers this behavior? Otherwise at some point this fix is going to revert and the issue is going to come back |
The navigation functions compare columns using lines.get_start_col() which returns visual column (with tab expansion). The current() function in targets.lua was returning byte column from nodes.get_scol(), causing sibling detection to fail when files use tabs for indentation. This fix changes current() to use visual column for the comparison, using the node's starting row (not cursor row) to handle cases where cursor is inside a multi-line node that starts on a different line. Fixes sibling navigation (Up/Down) in files with tab indentation.
Tests the visual column fix by using Go files (which use tabs by convention). Validates that move_down/move_up correctly navigate between sibling nodes at the same indentation level when the file uses tab characters. Test cases: - var declarations as siblings - if blocks as siblings - top-level function declarations
ahdzib-maya
force-pushed
the
fix/visual-column-calculation
branch
from
c7d6751 to
7ed3794
Compare
aaronik
approved these changes
Dec 10, 2025
Owner
|
Fantastic, thanks for the PR @ahdzib-maya! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
get_scol()function returns byte-based column (treesitter offset + 1) whilelines.get_start_col()returns visual column with tab expansion.This mismatch causes sibling navigation (Up/Down) to fail when files use tabs for indentation. The column comparison in
get_neighbor_at_same_col()requires exact match (candidate_col == scol), but:get_scol()returns byte column (e.g., 3 for\t\tvar)get_start_col()returns visual column (e.g., 9 with tabstop=4)So siblings at the same indentation are rejected because
9 == 3is false.Interestingly,
get_down_and_in()(Right movement) usescandidate_col > scol, which accidentally passes (9 > 3), making Right work for sibling navigation while Down doesn't.Solution
Change
get_scol()to return the visual column usinglines.get_start_col(), making it consistent with how candidate columns are calculated.Testing
Tested with Go files using tabs for indentation. Before the fix,
j/k(Down/Up) couldn't navigate between sibling statements inside a block. After the fix, sibling navigation works correctly.