[채이] 3-CustomVideoPlayer #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaeiJeon
requested review from
11t518s,
SaaaHoP,
dltkdals224,
leehyewon0531 and
yoon-junseo
SaaaHoP
reviewed
Apr 2, 2022
Member
SaaaHoP
left a comment
SaaaHoP
left a comment
There was a problem hiding this comment.
수고하셨습니다~ 간단하고 깔끔하게 코드 짜신거 같아요
전채이/CustomVideoPlayer/js/index.js
Outdated
Member
There was a problem hiding this comment.
stopButton은 동영상을 0초로 보내줘야 하는데 pauseVideo() 함수는 0으로 보내는게 없는거 같아요...?
Contributor
Author
There was a problem hiding this comment.
일시정지 버튼이었는데 정지 버튼으로 수정하겠습니다!
전채이/CustomVideoPlayer/js/index.js
Outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.