-
Notifications
You must be signed in to change notification settings - Fork 2
[상민] 3-CustomMoviePlayer #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dltkdals224
wants to merge
4
commits into
main
Choose a base branch
from
Sangmin/3-CustomVideoPlayer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+284
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| /* SOURCE: https://css-tricks.com/styling-cross-browser-compatible-range-inputs-css/ */ | ||
|
|
||
| input[type="range"] { | ||
| -webkit-appearance: none; /* Hides the slider so that custom slider can be made */ | ||
| width: 100%; /* Specific width is required for Firefox. */ | ||
| background: transparent; /* Otherwise white in Chrome */ | ||
| } | ||
|
|
||
| input[type="range"]::-webkit-slider-thumb { | ||
| -webkit-appearance: none; | ||
| } | ||
|
|
||
| input[type="range"]:focus { | ||
| outline: none; /* Removes the blue border. You should probably do some kind of focus styling for accessibility reasons though. */ | ||
| } | ||
|
|
||
| input[type="range"]::-ms-track { | ||
| width: 100%; | ||
| cursor: pointer; | ||
|
|
||
| /* Hides the slider so custom styles can be added */ | ||
| background: transparent; | ||
| border-color: transparent; | ||
| color: transparent; | ||
| } | ||
|
|
||
| /* Special styling for WebKit/Blink */ | ||
| input[type="range"]::-webkit-slider-thumb { | ||
| -webkit-appearance: none; | ||
| border: 1px solid #000000; | ||
| height: 36px; | ||
| width: 16px; | ||
| border-radius: 3px; | ||
| background: #ffffff; | ||
| cursor: pointer; | ||
| margin-top: -14px; /* You need to specify a margin in Chrome, but in Firefox and IE it is automatic */ | ||
| box-shadow: 1px 1px 1px #000000, 0px 0px 1px #0d0d0d; /* Add cool effects to your sliders! */ | ||
| } | ||
|
|
||
| /* All the same stuff for Firefox */ | ||
| input[type="range"]::-moz-range-thumb { | ||
| box-shadow: 1px 1px 1px #000000, 0px 0px 1px #0d0d0d; | ||
| border: 1px solid #000000; | ||
| height: 36px; | ||
| width: 16px; | ||
| border-radius: 3px; | ||
| background: #ffffff; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| /* All the same stuff for IE */ | ||
| input[type="range"]::-ms-thumb { | ||
| box-shadow: 1px 1px 1px #000000, 0px 0px 1px #0d0d0d; | ||
| border: 1px solid #000000; | ||
| height: 36px; | ||
| width: 16px; | ||
| border-radius: 3px; | ||
| background: #ffffff; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| input[type="range"]::-webkit-slider-runnable-track { | ||
| width: 100%; | ||
| height: 8.4px; | ||
| cursor: pointer; | ||
| box-shadow: 1px 1px 1px #000000, 0px 0px 1px #0d0d0d; | ||
| background: #3071a9; | ||
| border-radius: 1.3px; | ||
| border: 0.2px solid #010101; | ||
| } | ||
|
|
||
| input[type="range"]:focus::-webkit-slider-runnable-track { | ||
| background: #367ebd; | ||
| } | ||
|
|
||
| input[type="range"]::-moz-range-track { | ||
| width: 100%; | ||
| height: 8.4px; | ||
| cursor: pointer; | ||
| box-shadow: 1px 1px 1px #000000, 0px 0px 1px #0d0d0d; | ||
| background: #3071a9; | ||
| border-radius: 1.3px; | ||
| border: 0.2px solid #010101; | ||
| } | ||
|
|
||
| input[type="range"]::-ms-track { | ||
| width: 100%; | ||
| height: 8.4px; | ||
| cursor: pointer; | ||
| background: transparent; | ||
| border-color: transparent; | ||
| border-width: 16px 0; | ||
| color: transparent; | ||
| } | ||
| input[type="range"]::-ms-fill-lower { | ||
| background: #2a6495; | ||
| border: 0.2px solid #010101; | ||
| border-radius: 2.6px; | ||
| box-shadow: 1px 1px 1px #000000, 0px 0px 1px #0d0d0d; | ||
| } | ||
| input[type="range"]:focus::-ms-fill-lower { | ||
| background: #3071a9; | ||
| } | ||
| input[type="range"]::-ms-fill-upper { | ||
| background: #3071a9; | ||
| border: 0.2px solid #010101; | ||
| border-radius: 2.6px; | ||
| box-shadow: 1px 1px 1px #000000, 0px 0px 1px #0d0d0d; | ||
| } | ||
| input[type="range"]:focus::-ms-fill-upper { | ||
| background: #367ebd; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| @import url("https://fonts.googleapis.com/css?family=Questrial&display=swap"); | ||
|
|
||
| * { | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| body { | ||
| font-family: "Questrial", sans-serif; | ||
| background-color: #666; | ||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| justify-content: center; | ||
| max-height: 100vh; | ||
| margin: 0; | ||
| } | ||
|
|
||
| h1 { | ||
| color: #fff; | ||
| } | ||
|
|
||
| .screen { | ||
| cursor: pointer; | ||
| width: 60%; | ||
| background-color: #000 !important; | ||
| border-top-left-radius: 10px; | ||
| border-top-right-radius: 10px; | ||
| } | ||
|
|
||
| .controls { | ||
| background: #333; | ||
| color: #fff; | ||
| width: 60%; | ||
| border-bottom-left-radius: 10px; | ||
| border-bottom-right-radius: 10px; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| padding: 10px; | ||
| } | ||
|
|
||
| .controls .btn { | ||
| border: 0; | ||
| background: transparent; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| .controls .fa-play { | ||
| color: #28a745; | ||
| } | ||
|
|
||
| .controls .fa-stop { | ||
| color: #dc3545; | ||
| } | ||
|
|
||
| .controls .fa-pause { | ||
| color: #fff; | ||
| } | ||
|
|
||
| .controls .timestamp { | ||
| color: #fff; | ||
| font-weight: bold; | ||
| margin-left: 10px; | ||
| } | ||
|
|
||
| .btn:focus { | ||
| outline: 0; | ||
| } | ||
|
|
||
| @media (max-width: 800px) { | ||
| .screen, | ||
| .controls { | ||
| width: 90%; | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <meta http-equiv="X-UA-Compatible" content="ie=edge" /> | ||
| <title>Custom Video Player</title> | ||
| <link | ||
| href="https://stackpath.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css" | ||
| rel="stylesheet" | ||
| integrity="sha384-wvfXpqpZZVQGK6TAh5PVlGOfQNHSoD2xbE+QkPxCAFlNEevoEH3Sl0sibVcOQVnN" | ||
| crossorigin="anonymous" | ||
| /> | ||
| <link rel="stylesheet" href="css/progress.css" /> | ||
| <link rel="stylesheet" href="css/style.css" /> | ||
| </head> | ||
| <body> | ||
| <h1>Custom Video Player</h1> | ||
| <video | ||
| src="videos/gone.mp4" | ||
| id="video" | ||
| class="screen" | ||
| poster="img/poster.png" | ||
| ></video> | ||
| <div class="controls"> | ||
| <button class="btn" id="play"> | ||
| <i class="fa fa-2x fa-play"></i> | ||
| </button> | ||
| <button class="btn" id="stop"> | ||
| <i class="fa fa-2x fa-stop"></i> | ||
| </button> | ||
| <input | ||
| type="range" | ||
| id="progress" | ||
| class="progress" | ||
| min="0" | ||
| max="100" | ||
| step="0.1" | ||
| value="0" | ||
| /> | ||
| <span class="timestamp" id="timestamp">00:00</span> | ||
| </div> | ||
|
|
||
| <script src="script.js"></script> | ||
| </body> | ||
| </html> | ||
|
|
||
| <!-- https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Client-side_web_APIs/Video_and_audio_APIs --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| const video = document.querySelector("#video"); | ||
|
|
||
| const playBtn = document.querySelector("#play"); | ||
| const playBtnProperty = playBtn.querySelector("i"); | ||
| const stopBtn = document.querySelector("#stop"); | ||
|
|
||
| const progress = document.querySelector(".progress"); | ||
| const timestamp = document.querySelector(".timestamp"); | ||
|
|
||
| const PutToPlay = () => { | ||
| playBtnProperty.classList.remove("fa-play"); | ||
| playBtnProperty.classList.add("fa-pause"); | ||
| }; | ||
| const PutToPause = () => { | ||
| playBtnProperty.classList.remove("fa-pause"); | ||
| playBtnProperty.classList.add("fa-play"); | ||
| }; | ||
|
|
||
| const adjustVideoPlay = () => { | ||
| video.paused ? video.play() : video.pause(); | ||
| video.paused ? PutToPause() : PutToPlay(); | ||
| }; | ||
|
|
||
| const resetTimestamp = () => { | ||
| video.currentTime = 0; | ||
| video.pause(); | ||
| PutToPause(); | ||
| }; | ||
|
|
||
| const adjustProgressBar = () => { | ||
| progress.value = (video.currentTime / video.duration) * 100; | ||
|
|
||
| let minutes = String(Math.floor(video.currentTime / 60)).padStart(2, "0"); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. minutes, seconds가 아래에서 바뀌지 않으니 let보다 const가 좋아보입니다!
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 저도 채이랑 같은 의견입니다^_^!b |
||
| let seconds = String(Math.floor(video.currentTime % 60)).padStart(2, "0"); | ||
|
|
||
| timestamp.innerHTML = `${minutes}:${seconds}`; | ||
| }; | ||
|
|
||
| const updateProgress = () => { | ||
| video.currentTime = (progress.value * video.duration) / 100; | ||
| }; | ||
|
|
||
| video.addEventListener("click", adjustVideoPlay); | ||
| playBtn.addEventListener("click", adjustVideoPlay); | ||
| stopBtn.addEventListener("click", resetTimestamp); | ||
|
|
||
| video.addEventListener("timeupdate", adjustProgressBar); | ||
|
|
||
| progress.addEventListener("change", updateProgress); | ||
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
성호님 1-FormValidator 코드 리뷰에서 봤는데 함수명에 전치사가 있으면 가독성을 저해한다고 합니다! To를 빼는 방식으로 함수명을 지어 보시는 게 좋을 것 같아요!