Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 16, 2026

Code cleanup and consistency fixes from PR review feedback.

Changes

  • Removed unused imports: VectorAbstract, ObjectEntity (multiple files), tps, bossSpawningInterval
  • Fixed comment typo: barrel"sbarrel's
  • Replaced isNaN with !isFinite: Commands.ts now properly rejects Infinity values in addition to NaN, removed redundant MAX_SAFE_INTEGER checks
  • Added factory spawning to Domination: Missing attemptFactorySpawn() call added for consistency with Team2/Team4/Tag/Mothership gamemodes
// Before: players always spawned at team base
public spawnPlayer(tank: TankBody, client: Client) {
    const team = this.decideTeam(client);
    TeamEntity.setTeam(team, tank);
    const teamBase = team.base;
    // ...
}

// After: attempt factory spawn first
public spawnPlayer(tank: TankBody, client: Client) {
    const team = this.decideTeam(client);
    TeamEntity.setTeam(team, tank);
    
    const success = this.attemptFactorySpawn(tank);
    if (success) return;
    
    const teamBase = team.base;
    // ...
}

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits January 16, 2026 16:41
…te, add factory spawning to Domination

Co-authored-by: abcxff <79597906+abcxff@users.noreply.github.com>
Co-authored-by: abcxff <79597906+abcxff@users.noreply.github.com>
Copilot AI changed the title [WIP] Add player spawning from factories feature Address code review feedback: remove unused imports, fix validation, add missing factory spawn Jan 16, 2026
@abcxff abcxff marked this pull request as ready for review January 16, 2026 16:45
Copilot AI requested a review from abcxff January 16, 2026 16:45
@abcxff abcxff merged commit cd13863 into factory2 Jan 16, 2026
2 checks passed
@abcxff abcxff deleted the copilot/sub-pr-185-again branch January 16, 2026 16:49
c86ec23b-fef1-4979-b2fa-b9adc351b8cc added a commit that referenced this pull request Jan 16, 2026
* factory test

* Update Arena.ts

* Fix boss death notif

* broadcast msg function

* whoops

* typescript

* safety

* fix crash

* update color properly

* admin fun cmd

* tag cleanup

* Crash fix

* speedup AI slightly

* move getRandomPosition to util

* Fix maze wall team

* factory spawn chance tweak

* Fix spawns

* Fix 4 teams base locations

* typo

* fix randompos for circles

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Address code review feedback: remove unused imports, fix validation, add missing factory spawn (#187)

* Initial plan

* Address review feedback: fix typos, remove unused imports, use isFinite, add factory spawning to Domination

Co-authored-by: abcxff <79597906+abcxff@users.noreply.github.com>

* Remove redundant MAX_SAFE_INTEGER checks with isFinite

Co-authored-by: abcxff <79597906+abcxff@users.noreply.github.com>

* Add back bounds checking for score and points in commands

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: abcxff <79597906+abcxff@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: abcxff <79597906+abcxff@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants