Conversation
SimonWoolf
reviewed
Aug 5, 2024
Member
SimonWoolf
left a comment
SimonWoolf
left a comment
There was a problem hiding this comment.
Note that if we use this approach this stat will need to be added to all the stats that this aggregates into (not just messages.outbound.realtime.messages.unbatchedCount, but also messages.outbound.realtime.all.unbatchedCount, messages.outbound.all.all.unbatchedCount, messages.all.all.unbatchedCount, plus the presence ones)
but let's discuss the approach first today
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://ably.atlassian.net/browse/REA-1946
Adding unbatched outbound stats counts to have a comparison point with the batched results. If batching is disabled, it should contain the same value as the simple
.countcounterpart stat.