[AIT-280] feat: Implement apply-on-ACK (RTO20) prototype#113
Draft
lawrence-forooghian wants to merge 1 commit intomainfrom
Draft
[AIT-280] feat: Implement apply-on-ACK (RTO20) prototype#113lawrence-forooghian wants to merge 1 commit intomainfrom
lawrence-forooghian wants to merge 1 commit intomainfrom
Conversation
Implement the apply-on-ACK feature which applies LiveObjects operations locally upon receipt of an ACK message, rather than waiting for the operation echo. This reduces perceived latency for users. Key changes: - Add appliedOnAckSerials set and bufferedAcks array to MutableState - Add PublishResult type containing serials array from ACK res[i].serials - Implement RTO9a3: Skip OBJECT messages already applied on ACK - Implement RTO5c9-11: Clear/process buffered ACKs on sync completion - Add publishAndApply() method for the main apply-on-ACK flow - Add canApplyOperationForAck/applyForAck helpers to LiveMap/LiveCounter - Integrate apply-on-ACK into set/remove/increment/decrement operations PublishResult.serials is an array where each element corresponds 1:1 to the ObjectMessages that were published. publishAndApply processes each message with its corresponding serial at the matching index. Note: Full functionality requires ably-cocoa changes: - CD2j: Add siteCode to ConnectionDetails - Update nosync_sendObject callback to include serials from ACK Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the apply-on-ACK feature which applies LiveObjects operations
locally upon receipt of an ACK message, rather than waiting for the
operation echo. This reduces perceived latency for users.
Key changes:
PublishResult.serials is an array where each element corresponds 1:1 to
the ObjectMessages that were published. publishAndApply processes each
message with its corresponding serial at the matching index.
Note: Full functionality requires ably-cocoa changes:
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com