Conversation
… of the SDK, so I'm editing this in place.
maratal
changed the title
ttypic
reviewed
May 21, 2024
Contributor
ttypic
left a comment
ttypic
left a comment
There was a problem hiding this comment.
I don't really like that we are mentioning test cases in the spec point, but changes look valid. What do you think @SimonWoolf?
Member
|
I agree with Evgeny on both counts I've never liked the "A test should exist..." spec items. IMO the spec should specify behaviour, and it should be up to the implementer to write whatever tests they need to be sure that they've implemented that behaviour. (And in any case, the spec isn't exhaustive about what tests to write). But if we are going to have that in the spec, no particular objection to this one |
ttypic
approved these changes
May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #190
This shouldn't alter the behavior of the SDK, so I'm editing this in place.