Remove bundling and fix deprecated spec item version references#408
Merged
SimonWoolf merged 2 commits intomainfrom Feb 5, 2026
Merged
Remove bundling and fix deprecated spec item version references#408SimonWoolf merged 2 commits intomainfrom
SimonWoolf merged 2 commits intomainfrom
Conversation
| *** @(RSL11a1)@ In languages where method overloading is supported, the first argument should also accept a @Message@ object (which must contain a populated @serial@ field) | ||
| ** @(RSL11b)@ The SDK must send a GET request to the endpoint @/channels/{channelName}/messages/{serial}@ | ||
| ** @(RSL11c)@ Returns the decoded @Message@ object for the specified message serial | ||
| * @(RSL12)@ This clause has been replaced by "@RSL15@":#RSL15. It was valid up to and including specification version 5.0.0. |
Collaborator
There was a problem hiding this comment.
This "it was valid up to and including" language is taken from the guidance in the CONTRIBUTING guide. Please could you change the guidance there?
lawrence-forooghian
added a commit
to ably/ably-cocoa
that referenced
this pull request
Jan 6, 2026
This has been non-required functionality for a long time and has been removed in the latest version of the spec (see [1]). [1] ably/specification#408
lawrence-forooghian
added a commit
to ably/ably-cocoa
that referenced
this pull request
Jan 7, 2026
This has been non-required functionality for a long time and has been removed in the latest version of the spec (see [1]). [1] ably/specification#408
lawrence-forooghian
added a commit
to ably/ably-cocoa
that referenced
this pull request
Jan 9, 2026
This has been non-required functionality for a long time and has been removed in the latest version of the spec (see [1]). [1] ably/specification#408
lawrence-forooghian
added a commit
to ably/ably-cocoa
that referenced
this pull request
Jan 9, 2026
This has been non-required functionality for a long time and has been removed in the latest version of the spec (see [1]). [1] ably/specification#408
Some removals that said 'xxx was valid up to and including spec version x.x.x' that didn't actually mean it was valid in version x.x.x, they meant it was removed as of x.x.x. Also others that just said TBD.
SimonWoolf
force-pushed
the
remove-bundling
branch
from
c631844 to
5a0db50
Compare
lawrence-forooghian
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're no longer allowing bundling in protocol v5.
Also there were some removals that said 'xxx was valid up to and including spec version x.x.x' that didn't actually mean it was valid in version x.x.x, they meant it was removed as of x.x.x. Also others that just said TBD. Fixed those, using wording giving the first version that they're not valid for rather than the last version they are valid for, which seems like the more directly-useful thing.