Handle missing CodebaseResource in ClamAV scan_for_virus#2023
Open
mr-raj12 wants to merge 1 commit intoaboutcode-org:mainfrom
Open
Handle missing CodebaseResource in ClamAV scan_for_virus#2023mr-raj12 wants to merge 1 commit intoaboutcode-org:mainfrom
mr-raj12 wants to merge 1 commit intoaboutcode-org:mainfrom
Conversation
in the CodebaseResource database (e.g., temporary files that were cleaned up), the function would crash with ObjectDoesNotExist. This fix catches that exception and logs an error message instead of crashing, allowing the scan to continue processing other files. Fixes aboutcode-org#2019 Signed-off-by: Mrityunjay Raj <mr.raj.earth@gmail.com>
mr-raj12
force-pushed
the
fix-clamav-missing-resource
branch
from
b627276 to
b46bf9c
Compare
Author
|
Hi @tdruez ! 👋 This PR addresses the issue where scan_for_virus could fail when the CodebaseResource is missing. Would appreciate your review when you have a moment. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ObjectDoesNotExistand log error instead of crashingFixes #2019
Test plan
test_scanpipe_pipes_clamav_scan_for_virus_missing_resource