Fix 1941 SPDX identifier normalization for license detection #2042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jayant-kernel
force-pushed
the
fix-1941-improve-license-detection
branch
3 times, most recently
from
48366be to
66bc57a
Compare
The license detection was returning deprecated SPDX identifiers like GPL-2.0 instead of the current GPL-2.0-only format. This caused issues when scanning Nixpkgs packages. Added a normalization function that maps old identifiers to current ones. Integrated it into the license data cleaning flow so it works automatically. Fixes aboutcode-org#1941 Signed-off-by: Jayant Saxena <jayantmcom@gmail.com>
Jayant-kernel
force-pushed
the
fix-1941-improve-license-detection
branch
from
66bc57a to
5301c0f
Compare
Author
|
@DennisClark @AyanSinhaMahapatra @JonoYang please review the pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When scanning Nixpkgs packages, ScanCode was detecting licenses with
old SPDX identifiers like
GPL-2.0instead of the current standardGPL-2.0-only. This caused mismatches between declared and detectedlicenses.
What I Did
Added a simple mapping function to normalize deprecated SPDX identifiers
to their current versions. The normalization happens automatically during
license detection data cleanup.
Changes
normalize_spdx_identifier()in scanpipe/pipes/scancode.pyTesting
Tested normalization for:
Fixes #1941