Fix #41: Add explicit binary detection for PDF files#48
Closed
Dreamstick9 wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Kushagar Garg <dreamstick909@gmail.com>
Author
|
@AyanSinhaMahapatra If you have some free time Could you please review this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some PDF files were being incorrectly identified as text because they start with a text header (%PDF-)
This change adds a check in src/typecode/contenttype.py
if a file is initially detected as text, it now looks for a %PDF- signature and correctly sets it to binary if found.
i also added a regression test in tests/test_testcontenttype.py to cover this case
Fixes #41