Skip to content

Migrate the NVD importer to use the 2.0 API schema #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TG1999 merged 3 commits into from
Jan 2, 2026
Merged

Migrate the NVD importer to use the 2.0 API schema #2012

TG1999 merged 3 commits into from
Jan 2, 2026

Conversation

@ziadhany
Copy link
Collaborator

@ziadhany ziadhany commented Oct 30, 2025 •
edited
Loading

ziadhany
ziadhany commented Dec 25, 2025
View reviewed changes
@ziadhany ziadhany force-pushed the nvd-update branch 2 times, most recently from 2ca2aae to e6ed93c Compare January 1, 2026 09:15
@ziadhany
Copy link
Collaborator Author

ziadhany commented Jan 1, 2026 •
edited
Loading

NVD logs:

nvd_importer_v2.zip

from vulnerabilities.models import AdvisoryV2
from django.db.models import Count
duplicates = (
    AdvisoryV2.objects
    .values('avid')
    .annotate(count=Count('id'))
    .filter(count__gt=1)
)
len(duplicates)
Out[4]: 0

AdvisoryV2.objects.count()
Out[3]: 295380

TG1999
TG1999 approved these changes Jan 2, 2026
View reviewed changes
Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ziadhany @TG1999
Update nvd test data
7904862 
Update NVD Importer v2 to use 2.0 API schema
Migrate nvd importer v1 to use 2.0 API schema

Signed-off-by: ziad hany <ziadhany2016@gmail.com>
@ziadhany @TG1999
Fix nvd importer to collect severities correctly
c1f4bab 
Add a test

Signed-off-by: ziad hany <ziadhany2016@gmail.com>
@ziadhany @TG1999
Add a test for nvd importer v2
5c8015a 
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
@TG1999 TG1999 merged commit 4171dbe into aboutcode-org:main Jan 2, 2026
5 of 6 checks passed
@ziadhany ziadhany deleted the nvd-update branch January 2, 2026 08:55
@ziadhany ziadhany mentioned this pull request Jan 2, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TG1999 TG1999 TG1999 approved these changes

@keshav-space keshav-space Awaiting requested review from keshav-space

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NVD Importer failing due to NVD Data Feed API changes

2 participants

@ziadhany @TG1999