Skip to content

Fix get_advisory_url to handle string file paths #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mr-raj12 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

Fix get_advisory_url to handle string file paths #2102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions vulnerabilities/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from collections import defaultdict
from functools import total_ordering
from http import HTTPStatus
from pathlib import Path
from typing import List
from typing import Optional
from typing import Tuple
Expand Down Expand Up @@ -543,6 +544,10 @@ def get_advisory_url(file, base_path, url):
"""
Return the advisory URL constructed by combining the base URL with the relative file path.
"""
if isinstance(file, str):
file = Path(file)
if isinstance(base_path, str):
base_path = Path(base_path)
relative_path = str(file.relative_to(base_path)).strip("/")
advisory_url = urljoin(url, relative_path)
return advisory_url
Expand Down