reject negative unnamed-type numbers in ParseUnnamedTypeName#2115
Open
nabhan06 wants to merge 1 commit into
Open
reject negative unnamed-type numbers in ParseUnnamedTypeName#2115nabhan06 wants to merge 1 commit into
nabhan06 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParseUnnamedTypeName bounds the unnamed-type
<number>only from above, so a negative one (from thenprefix, or from ParseNumber truncating its accumulator to int) still reaches MaybeAppendDecimal, which documents a positive value and evaluates(val % 10) + '0'per digit, emitting bytes below '0' --_ZUtn3_demangles to{unnamed type#/}and_ZUt2147483648_to{unnamed type#./,),(-*,*}, both returning true -- so add the matching lower bound on both theUtandUlbranches, keeping the -1 sentinel that denotes an omitted number, the same straining ParseLocalNameSuffix already does for<(parameter) number>.