Skip to content

Fix hash_instantiated_test and hash_test on big-endian #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
miladfarca wants to merge 2 commits into from
+12 −0
Closed

Fix hash_instantiated_test and hash_test on big-endian #2120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
192f02c
Fix
miladfarca Jul 20, 2026
955225b
update
miladfarca Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions absl/hash/internal/hash.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,6 +809,9 @@ AbslHashValue(H hash_state, const std::vector<T, Allocator>& vector) {
for (size_t j = 0; j < 64; ++j) {
word |= static_cast<uint64_t>(vector[i + j]) << j;
}
if constexpr (absl::endian::native == absl::endian::big) {
word = absl::byteswap(word);
}
hash_state = combiner.add_buffer(
std::move(hash_state), reinterpret_cast<const unsigned char*>(&word),
sizeof(word));
Expand All @@ -821,6 +824,9 @@ AbslHashValue(H hash_state, const std::vector<T, Allocator>& vector) {
for (size_t j = 0; j < rem; ++j) {
word |= static_cast<uint64_t>(vector[i + j]) << j;
}
if constexpr (absl::endian::native == absl::endian::big) {
word = absl::byteswap(word);
}
hash_state = combiner.add_buffer(
std::move(hash_state), reinterpret_cast<const unsigned char*>(&word),
(rem + 7) / 8);
Expand Down Expand Up @@ -988,6 +994,9 @@ H AbslHashValue(H hash_state, const std::bitset<N>& set) {
for (size_t j = 0; j < 64; ++j) {
word |= static_cast<uint64_t>(set[i + j]) << j;
}
if constexpr (absl::endian::native == absl::endian::big) {
word = absl::byteswap(word);
}
hash_state = combiner.add_buffer(
std::move(hash_state), reinterpret_cast<const unsigned char*>(&word),
sizeof(word));
Expand All @@ -1000,6 +1009,9 @@ H AbslHashValue(H hash_state, const std::bitset<N>& set) {
for (size_t j = 0; j < rem; ++j) {
word |= static_cast<uint64_t>(set[i + j]) << j;
}
if constexpr (absl::endian::native == absl::endian::big) {
word = absl::byteswap(word);
}
hash_state = combiner.add_buffer(
std::move(hash_state), reinterpret_cast<const unsigned char*>(&word),
(rem + 7) / 8);
Expand Down