POC: Typescript Conversion playground WIP. Do Not Merge#73
Closed
D4RKAR117 wants to merge 7 commits intoabsolute-version:cli-update-and-typescript-conversion-wipfrom
D4RKAR117:feat/typescript-esm
Closed
POC: Typescript Conversion playground WIP. Do Not Merge#73D4RKAR117 wants to merge 7 commits intoabsolute-version:cli-update-and-typescript-conversion-wipfrom D4RKAR117:feat/typescript-esm
D4RKAR117 wants to merge 7 commits intoabsolute-version:cli-update-and-typescript-conversion-wipfrom
D4RKAR117:feat/typescript-esm
Conversation
- Changed default package manager from npm to pnpm - Updated project dependencies BREAKING CHANGE: Changed npm in favor of pnpm
- Added Typescript support for eslint - Added typescript and basic tsconfig
- Updated .gitignore file to cover more workflows using gitignore.io - Added .eslintignore with basic rules
…forcement - Added husky for git hooks management - Added commit-msg hook with conventional commits spec validation using commitlint - Added commitlint.config.cts and commitizen config\scripts to do a propper commit without effort (use pnpm commit)
- Changed project structure to match more concise spec for typescript - Changed file module resolution from cjs to esm - Added missing types packages - Preparation to migrate test to vitest BREAKING CHANGE: Changed project structure and module resolution to support typescript and esm "fix #29"
- Added basic typings for config spec - Added improved preset spec resolving using esm 'import.meta.resolve' fallback to node resolve
- Modified command manager to cast better types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm creating this PR without intention of it to get merged. (at least at the near future) So everything here its just to benefit the main effort of typescript transition.
I will use it to make more aggressive changes that can benefit the typescript conversion currently leaded by @helmturner on #69 as POC to test new approaches for some things that can be improved.
Some of those things are:
This could help to test some ideas that could be a little too aggressive to follow up, and help the main effort to have a second opinion on the transition towards a modern typescript and esm library.
Thanks to @TimothyJones to allow me to do this.