Skip to content

[codex] Fix Sonar TypeScript config resolution #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
davideluque wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[codex] Fix Sonar TypeScript config resolution #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/sonarqube.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ jobs:
- uses: actions/checkout@v6
with:
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
- uses: actions/setup-node@v6
with:
node-version-file: '.tool-versions'
cache: 'npm'
- run: npm ci
- uses: SonarSource/sonarqube-scan-action@v7
env:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
Expand Down
1 change: 1 addition & 0 deletions sonar-project.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
sonar.projectKey=abtion_adonisjs-template_e6981c04-79a9-46d2-9b70-6706c53d1f55
sonar.typescript.tsconfigPaths=tsconfig.json,inertia/tsconfig.json

@gemini-code-assist gemini-code-assist Bot Apr 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Explicitly defining sonar.typescript.tsconfigPaths addresses the resolution issue for Sonar, but there is an underlying inconsistency in the project configuration. The root tsconfig.json (line 8) references ./tsconfig.inertia.json, yet the actual file is located at inertia/tsconfig.json.

By correcting the reference in the root tsconfig.json to point to ./inertia/tsconfig.json, Sonar (and the TypeScript compiler) would be able to resolve the entire project structure naturally. This would also allow you to simplify the Sonar configuration to just the root config, avoiding potential double-analysis or metric inflation that can occur when overlapping configurations are listed explicitly.

Loading