Move Escape Room breadcrumbs from hero to header#559
Conversation
…o for escape room pages.
✅ Deploy Preview for accessiblecommunity ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
If this approach is approved, I can go ahead an remove the HeroWithBreadcrumbs component, as it would no longer be used. |
brian-montgomery
left a comment
brian-montgomery
left a comment
There was a problem hiding this comment.
Hey Alexis. Your concept looks good, although all of the breadcrumbs are showing up a bit incorrectly (see below).
Let me run this by Rachael and see what she thinks about it.
There was a problem hiding this comment.
You didn't update the Layout to pass the crumbs into the ERHeader, so they are all showing up as the default. You need to pass the crumbs to the Layout and in the Layout, pass the crumbs to the HeaderER component.
brian-montgomery
force-pushed
the
alexis/escape-room-crumbs
branch
from
e5c4f56 to
78e0f7a
Compare
brian-montgomery
left a comment
brian-montgomery
left a comment
There was a problem hiding this comment.
Alexis, I went ahead and modified the EscapeRoomLayout to take the breadcrumbs from a page and pass it to the Header.
I also changed the default 'Home' to be the escape room main page.
2 participants
Fixes #404