Open
Conversation
allo-
force-pushed
the
fix_infer_api
branch
2 times, most recently
from
d113da6 to
42b302b
Compare
When save_path is a filename without directory, os.dirname(save_path) is an empty string and ensure_directory fails. This adds a check if the directory variable contains an empty string before running os.makedirs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The infer-api.py script does not set the new
formatparameter. Usingsave_pathwith a filename was also broken and I added a commit that fixed that for the example script in discussion #183.