-
Notifications
You must be signed in to change notification settings - Fork 191
Dqt improvements define fields #10162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@marandmart sorry it took so long but I was waiting for the translation of the dataquery module to be merged. Can you rebase this and then I'll test it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't very important but I think it's a little strange that "Select a field" is smaller than "Selected fields"

Personally I think we do need a visit selection before syncing visit fields in case different visits should be selected for different fields

There are some conflicts to resolve as well
Otherwise it looks great!
Brief summary of changes
Updated placement of UI elements
Previously
Updated
Link(s) to related issue(s)
558: https://github.com/aces/CBIGR/issues/558