Skip to content

Make IpNetwork::mask const #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
achanda merged 3 commits into from
Jan 8, 2025
Merged

Make IpNetwork::mask const #207

achanda merged 3 commits into from
Jan 8, 2025

Conversation

@MarkusPettersson98
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 commented Jan 7, 2025 •
edited
Loading

This PR makes IpNetwork::mask and thereby Ipv4Network::mask and Ipv6Network::mask const.

Is this too invasive? Ipv{4,6}Addr::from_bits was introduced in Rust 1.80. If this change was to be accepted, it would unlock more const-ification through Ipv{4,6}Addr::to_bits as well!

@achanda achanda merged commit 9ae7196 into achanda:master Jan 8, 2025
3 checks passed
This was referenced Jan 8, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarkusPettersson98 @achanda