Refactor date functions to use date fns date fns tz#149
Merged
christianhelp merged 11 commits intodevfrom Apr 7, 2025
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (2)
apps/web/src/lib/queries/charts.ts:202
- Using a default value of 1 for currentMonthCount may artificially inflate the growth rate when there are no events in the current month; please verify that this logic reflects the intended behavior.
const currentMonthCount = currentMonthResult[0]?.count || 1;
apps/web/src/components/dash/admin/events/EditEventForm.tsx:133
- Consider adding eventEndTime to the dependency array for accurate re-evaluation of the condition when editing event times.
useEffect(() => {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Currently, a lot of the date comparison logic inside of the event section is being done by functions we create instead of using the built-in libraries. Could lead to issue later on if not fixed.
What
Performed refactors and slight other enhancements to satisfy this
Satisfies
#80