Removed user_agent_type label from http metrics#57
Merged
vasayxtx merged 1 commit intoacronis:masterfrom Dec 23, 2025
Merged
Conversation
xray33
force-pushed
the
feature/remove_user_agent_type_label
branch
2 times, most recently
from
fc16049 to
2298b2a
Compare
xray33
force-pushed
the
feature/remove_user_agent_type_label
branch
from
2298b2a to
e017193
Compare
vasayxtx
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed default value for label user_agent_type in HTTP metrics.
It will reduce cardinality of metrics by 2.
While this label is not really used.
And if it still needed by someone, it is possible to set custom GetUserAgentType function in options.