-
Notifications
You must be signed in to change notification settings - Fork 65
feat: Add SVM destination support for CCTP strategy #2049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dohaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Just one nit about the ongoing conversation
dohaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Is the SVM finalizer in prod already though? We should probably enable this in the API after the finalizer is ready right?
Yup I'll merge them in order. Going to push the finalizer changes first to my release branch and if everything looks good, I'll merge this. |
melisaguevara
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!!
amateima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging this we should test the entire flow with the indexer and finalizer bot
Yeah I tested it end to end: swap API -> indexer -> finalizer and it's working well. Here is one finalize transaction for example. |
|
@ashwinrava Deposit status page supports this now #2137 |
Changes:
test/api/_bridges/cctp/strategy.test.ts.Testing: I tested locally by creating a deposit transaction from the swap API (without marker to avoid the prod finalizer from picking it up) and ran the finalizer code locally to confirm the mint works as expected.