Make SDK more pythonic#1
Open
timothyaaron wants to merge 2 commits intoactionably:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This introduces breaking changes. Namely, class/function names use Python conventions, also parameters are passed as dictionaries (instead of having to json.dump existing dictionaries, just so the SDK can json.load them).
I understand if these changes are just not viable do to breaking changes, but wanted to show what the SDK should look like stylistically and leveraging inheritance and such.
Also, as I'm having trouble getting Dashbot to work at all, at the moment, this is untested and may include some typos.