Ensure dist directory is removed and rebuilt #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [@rollup/plugin-commonjs](https://github.com/rollup/plugins/tree/HEAD/packages/commonjs) from 28.0.8 to 29.0.0. - [Changelog](https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/commonjs-v29.0.0/packages/commonjs) --- updated-dependencies: - dependency-name: "@rollup/plugin-commonjs" dependency-version: 29.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the npm-development group with 4 updates in the / directory: [eslint](https://github.com/eslint/eslint), [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest), [prettier](https://github.com/prettier/prettier) and [rollup](https://github.com/rollup/rollup). Updates `eslint` from 9.38.0 to 9.39.1 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.38.0...v9.39.1) Updates `eslint-plugin-jest` from 29.0.1 to 29.2.1 - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases) - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md) - [Commits](jest-community/eslint-plugin-jest@v29.0.1...v29.2.1) Updates `prettier` from 3.6.2 to 3.7.3 - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.6.2...3.7.3) Updates `rollup` from 4.52.5 to 4.53.3 - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.52.5...v4.53.3) --- updated-dependencies: - dependency-name: eslint dependency-version: 9.39.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-development - dependency-name: eslint-plugin-jest dependency-version: 29.2.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-development - dependency-name: prettier dependency-version: 3.7.3 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-development - dependency-name: rollup dependency-version: 4.53.3 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-development ... Signed-off-by: dependabot[bot] <support@github.com>
…lugin-commonjs-29.0.0' into ncalteen/dist
There was a problem hiding this comment.
Pull request overview
This pull request enhances the build process by ensuring the dist/ directory is cleaned before packaging, and updates several development dependencies to their latest versions.
Key Changes:
- Adds
rimraf ./distcleanup to the package script for consistent builds - Introduces a CI workflow step to remove
dist/before dependency installation - Updates 5 development dependencies: @rollup/plugin-commonjs, eslint, eslint-plugin-jest, prettier, and rollup
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Modified package script to clean dist/ before building; updated 5 devDependencies to latest versions |
| package-lock.json | Lockfile updates reflecting the dependency version changes, including transitive dependency updates |
| dist/index.js | Regenerated bundle with updated dependencies (variable renaming to avoid conflicts, updated imports) |
| .github/workflows/check-dist.yml | Added step to remove dist/ directory before installing dependencies in CI |
Note: The main issues identified are that rimraf is used via npx in both package.json and the CI workflow, but it's not explicitly listed in devDependencies. While it exists as a transitive dependency (v3.0.2), this version is deprecated and its availability is not guaranteed. Adding rimraf as an explicit devDependency with a current version (e.g., ^6.0.0) would make the build process more reliable and maintainable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the build process by ensuring the
dist/directory is always cleaned before packaging, both locally and in CI, and updates several development dependencies to their latest versions.