Skip to content

Implement dual-module build (ESM + CJS) #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colinhacks wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Implement dual-module build (ESM + CJS) #2122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5bd77ef
Implememnt dual-module build with zshy
colinhacks Aug 28, 2025
75d27f7
Revert lockfile and tsconfig changes
colinhacks Aug 28, 2025
372f8b2
Undo more changes
colinhacks Aug 28, 2025
2e65889
Undo lockfile changes
colinhacks Aug 28, 2025
4d851a1
Update root lockfile
colinhacks Aug 28, 2025
4fbc933
Closes #1770
colinhacks Aug 28, 2025
34a8100
Tweak
colinhacks Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
234 changes: 226 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
"scripts": {
"audit-all": "lerna run audit-moderate",
"bootstrap": "lerna exec -- npm install",
"build": "lerna run tsc",
"build": "lerna run build",
"clean": "lerna clean",
"repair": "lerna repair",
"check-all": "concurrently \"npm:format-check\" \"npm:lint\" \"npm:test\" \"npm:build -- -- --noEmit\"",
"check-all": "concurrently \"npm:format-check\" \"npm:lint\" \"npm:test\" \"npm:build\"",
"format": "prettier --write packages/**/*.ts",
"format-check": "prettier --check packages/**/*.ts",
"lint": "eslint packages/**/*.ts",
Expand All @@ -31,6 +31,7 @@
"nx": "16.6.0",
"prettier": "^3.0.0",
"ts-jest": "^29.1.1",
"typescript": "^5.2.2"
"typescript": "^5.2.2",
"zshy": "^0.3.5"
}
}
}
18 changes: 16 additions & 2 deletions packages/artifact/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@
],
"homepage": "https://github.com/actions/toolkit/tree/main/packages/artifact",
"license": "MIT",
"main": "lib/artifact.js",
"types": "lib/artifact.d.ts",
"main": "./lib/artifact.js",
"module": "./lib/artifact.mjs",
"types": "./lib/artifact.d.ts",
"directories": {
"lib": "lib",
"test": "__tests__"
Expand All @@ -34,6 +35,7 @@
"bootstrap": "cd ../../ && npm run bootstrap",
"tsc-run": "tsc",
"tsc": "npm run bootstrap && npm run tsc-run",
"build": "zshy",
"gen:docs": "typedoc --plugin typedoc-plugin-markdown --out docs/generated src/artifact.ts --githubPages false --readme none"
},
"bugs": {
Expand All @@ -60,5 +62,17 @@
"typedoc": "^0.25.4",
"typedoc-plugin-markdown": "^3.17.1",
"typescript": "^5.2.2"
},
"zshy": {
"exports": {
".": "./src/artifact.ts"
}
},
"exports": {
".": {
"types": "./lib/artifact.d.ts",
"import": "./lib/artifact.mjs",
"require": "./lib/artifact.js"
}
}
}
Loading