Moves away from Omnitruck to Chef Community + adds License param needed for commercial endpoint

[san983]

Description

As Omnitruck is scheduled to reach its End of Life (EOL) by mid-2025. I'm pushing this PR to move away from Omnitruck endpoint, defaulting to Chef Community endpoint and adding the license param required for Chef Commercial endpoint

Issues Resolved

• Omnitruck deprecation

Check List

• New functionality includes testing.
• New functionality has been documented in the README if applicable.

[san983]

@damacus could you please take a look here? Thanks!

[damacus]

@xorima is actually looking at this area. So I'll hand over to him 👍

[xorima]

Hey, there is a branch for this already (which I'm very struggling with getting working, no lie) the aim is to support the new chef ways of installing

BUT

Chef 19's new install method is not yet there for every OS, so will need some time and I need to work with Cinc to ensure they are also supported

PR in question: #33

[san983]

Hey, there is a branch for this already (which I'm very struggling with getting working, no lie) the aim is to support the new chef ways of installing

BUT

Chef 19's new install method is not yet there for every OS, so will need some time and I need to work with Cinc to ensure they are also supported

PR in question: #33

Thanks for your input. So may I ask if it makes sense to keep this PR? Actually I was not able to review #33 as it's a huge diff.

[xorima]

Can we keep this and if this is set to something different then default we use omnitruckUrl otherwise we use chefDownloadUrl to maintain backwards compatability, else when this is merged I fear a few customers will have things break

[xorima]

this seems sensible enough to keep until chef 19 is working for everyone,

Hey, there is a branch for this already (which I'm very struggling with getting working, no lie) the aim is to support the new chef ways of installing
BUT
Chef 19's new install method is not yet there for every OS, so will need some time and I need to work with Cinc to ensure they are also supported
PR in question: #33

Thanks for your input. So may I ask if it makes sense to keep this PR? Actually I was not able to review #33 as it's a huge diff.

I'm happy to get this in and working, just want a minor backwards compatability fix for now and when chef 19 is fully supported a wider how this should work can be discussed :)