Skip to content

Upgrade GitHub Actions to node24-compatible versions#7

Merged
lolaruAP merged 7 commits intomasterfrom
sc-106243/upgrade-actions-versions-to-use-node-24
May 4, 2026
Merged

Upgrade GitHub Actions to node24-compatible versions#7
lolaruAP merged 7 commits intomasterfrom
sc-106243/upgrade-actions-versions-to-use-node-24

Conversation

@lolaruAP
Copy link
Copy Markdown
Contributor

Summary

(systematically-generated PR)

Node 20 EOL is in April-- this PR pins all node-based reusable GitHub Actions to the SHA of the latest available node24 version

This PR may or may not also include other edits to account for relevant breaking changes in the actions

Copy link
Copy Markdown
Contributor

@johnrb2 johnrb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes so this PR only preserves workflow updates that are still needed on the base branch.

Changes that still appear worth preserving:

  • .github/workflows/codeql-analysis.yml: base still has unpinned action refs: actions/checkout@v3, github/codeql-action/init@v2, github/codeql-action/autobuild@v2, github/codeql-action/analyze@v2
    • Still unaddressed in this file: github/codeql-action/init@v2, github/codeql-action/autobuild@v2, github/codeql-action/analyze@v2
  • .github/workflows/release.yml: base still has unpinned action refs: actions/checkout@v3, actions/setup-node@v3

Please update this PR or replace it with a narrower follow-up that keeps only the still-needed SHA pins.

@johnrb2
Copy link
Copy Markdown
Contributor

johnrb2 commented Apr 29, 2026

Added a follow-up commit for sc-106243 to standardize this PR.

  • Category: D1
  • Commit: 1d3286ec27ee32bde7998a356678b1071b3bc3f0
  • Changes: remove package-lock=false from .npmrc, generate/update package-lock.json

I will verify CI next and approve once the migration is green.

@johnrb2
Copy link
Copy Markdown
Contributor

johnrb2 commented Apr 29, 2026

Not approving yet: CI status is ci-needs-manual. no checks reported on the 'sc-106243/upgrade-actions-versions-to-use-node-24' branch

@johnrb2
Copy link
Copy Markdown
Contributor

johnrb2 commented Apr 29, 2026

Added a follow-up commit for sc-106243 to standardize this PR.

  • Category: D1
  • Commit: aa45a7ecd1fa152983097a2e6c58686b32fc1366
  • Changes: rewrite .github/workflows/release.yml to shared release workflow caller

I will verify CI next and approve once the migration is green.

johnrb2
johnrb2 previously approved these changes Apr 29, 2026
- Delete CodeQL workflow (replaced by Codecov coverage reporting)
- Enable codecov: true in shared test workflow caller
johnrb2 added 2 commits April 29, 2026 12:51
Made-with: Cursor
…rkflows)

integration-harness is public; github-action-workflows is private.
GitHub does not allow public repos to call reusable workflows from
private repos. Use equivalent inline workflow with same SHA-pinned
actions and node matrix [20.x, 24.x].

Made-with: Cursor
Copy link
Copy Markdown
Contributor

@johnrb2 johnrb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI green. Inline workflow (public repo can't call private reusable workflows) + codeql removal + codecov enabled.

@lolaruAP lolaruAP merged commit ff2eb13 into master May 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants