Open
Conversation
modified: lib/docx_replace.rb
modified: lib/docx_replace/version.rb
By default method `matches` return the exactly same output as `unique_matches`. Now matches returns a hash of matched values with counted repetitions:
{
"matched_value_1": 1,
"matched_value_2": 4
}
Owner
|
Oh yeah I guess I hadn't noticed that it doesn't actually return the unique matches. But since the code you wrote returns a different type of data structure (hash instead of array), I'd rather it be a different method altogether. This will also ensure that it doesn't break compatibility. So could you put your code inside a new method called |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to be committed:
modified: lib/docx_replace.rb
modified: lib/docx_replace/version.rb
By default method
matchesreturn the exactly same output asunique_matches. Now matches returns a hash of matched values with counted repetitions:{
"matched_value_1": 1,
"matched_value_2": 4
}