This repository was archived by the owner on Apr 18, 2023. It is now read-only.
Open
Conversation
belongs_to is now explicitly required in the Rails 5 beta. In this situation, an optional parent_id is needed to set a root page with no parent.
|
If this PR is updated, what else is necessary for rails 5 support? I see this fork: https://github.com/NarasimhaReddyY/documentation from @narasimhareddy has a few more changes for 5.1 which looks promising. Might you have any time to look at this @adamcooke ? |
|
I believe that I got it running by adding the "[5.2]" to the migrations (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
belongs_to is now explicitly required in the Rails 5 beta. In this situation, an optional parent_id is needed to set a root page with no parent.
Not sure if you want to pull in changes for the beta version of Rails 5 - but I figured I would send it your way and let you decide.
Cheers.