docs(sccm): harden client health workflow corpus (#320) - #340
Merged
adamgell merged 3 commits intoJul 30, 2026
Conversation
Owner
Author
|
@coderabbitai full review Please review the full #320 corpus range for marker/framing integrity, physical-versus-logical identity, shared-source membership, exact capture provenance, conservative incomplete/malformed/rotation behavior, keyed recovery/contradiction separation, and no production/native claims. |
|
Warning Review limit reached
Next review available in: 2 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (22)
📒 Files selected for processing (20)
Comment |
|
✅ Action performedFull review finished. Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 43 minutes. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a synthetic, preparation-only SCCM client-health corpus for issue #320, documenting intended conservative diagnostic behavior and providing scenario fixtures (manifests, expected outcomes, and minimal CCM-style evidence) without introducing production code or public contracts ahead of #318/#319.
Changes:
- Add a preparation spec document describing scope, workflow boundaries, scenario matrix, and future test expectations for SCCM client-health.
- Add nine scenario fixture bundles under
cmtraceopen-parsertests/fixtures, each with a proposedmanifest.json,expected.json, and only the referenced evidence files. - Include explicit malformed/fragment/rotation-boundary evidence cases to constrain future reducer behavior conservatively.
Reviewed changes
Copilot reviewed 20 out of 42 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/sccm/preparation/issue-320-client-health-corpus.md | Corpus preparation spec, scenario matrix, and future test/reducer constraints for #320. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/transport-failure/manifest.json | Proposed fixture manifest for the transport-failure scenario. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/transport-failure/expected.json | Proposed expected workflow/finding output contract for transport-failure. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/transport-failure/evidence/client-location-services-shared/current/LocationServices.log | Synthetic CCM evidence for MP selection + transport request/terminal failure correlation. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/transport-failure/evidence/client-identity/current/ClientIDManagerStartup.log | Synthetic CCM evidence for identity registration success (pre-transport). |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/transport-failure/evidence/client-evaluation/current/CcmEval.log | Synthetic CCM evidence for service evaluation success (pre-identity). |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/transport-failure/evidence/client-ccmsetup/current/ccmsetup.log | Synthetic CCM evidence for bootstrap completion (pre-service). |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/success/manifest.json | Proposed fixture manifest for the success scenario. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/success/expected.json | Proposed expected workflow output contract for success (no diagnosis). |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/success/evidence/client-location-services-shared/current/LocationServices.log | Synthetic CCM evidence for site assignment + MP selection + transport success. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/success/evidence/client-identity/current/ClientIDManagerStartup.log | Synthetic CCM evidence for identity registration success. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/success/evidence/client-evaluation/current/CcmEval.log | Synthetic CCM evidence for service evaluation success. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/success/evidence/client-ccmsetup/current/ccmsetup.log | Synthetic CCM evidence for bootstrap completion. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/setup-failure/manifest.json | Proposed fixture manifest for the setup-failure scenario (downstream artifacts absent). |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/setup-failure/expected.json | Proposed expected workflow/finding output contract for setup-failure. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/setup-failure/evidence/client-ccmsetup/current/ccmsetup.log | Synthetic CCM evidence for terminal bootstrap/setup failure. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/rotation-boundary/manifest.json | Proposed fixture manifest for rotation-boundary (split/incomplete rotations). |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/rotation-boundary/expected.json | Proposed expected workflow/finding output contract for rotation-boundary. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/rotation-boundary/evidence/client-ccmsetup/lo/ccmsetup.log.lo_ | Synthetic split-record fragment (rotation .lo_) for rotation-boundary case. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/rotation-boundary/evidence/client-ccmsetup/current/ccmsetup.log | Synthetic split-record fragment (current) for rotation-boundary case. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/no-site-or-mp/manifest.json | Proposed fixture manifest for no-site-or-mp scenario. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/no-site-or-mp/expected.json | Proposed expected workflow/finding output contract for no-site-or-mp. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/no-site-or-mp/evidence/client-location-services-shared/current/LocationServices.log | Synthetic evidence for incomplete location/site/MP sequence + unkeyed transport symptom. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/no-site-or-mp/evidence/client-identity/current/ClientIDManagerStartup.log | Synthetic identity registration success evidence. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/no-site-or-mp/evidence/client-evaluation/current/CcmEval.log | Synthetic service evaluation success evidence. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/no-site-or-mp/evidence/client-ccmsetup/current/ccmsetup.log | Synthetic bootstrap completion evidence. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/malformed/manifest.json | Proposed fixture manifest for malformed scenario (unclosed CCM record). |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/malformed/expected.json | Proposed expected workflow/finding output contract for malformed. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/malformed/evidence/client-evaluation/current/CcmEval.log | Synthetic malformed/unclosed CCM record evidence for service/evaluation. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/malformed/evidence/client-ccmsetup/current/ccmsetup.log | Synthetic bootstrap completion evidence (pre-malformed hop). |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/incomplete/manifest.json | Proposed fixture manifest for incomplete scenario (access-denied + absent coverage). |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/incomplete/expected.json | Proposed expected workflow/finding output contract for incomplete. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/incomplete/evidence/client-evaluation/current/CcmEval.log | Synthetic service evaluation success evidence (pre-coverage gaps). |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/incomplete/evidence/client-ccmsetup/current/ccmsetup.log | Synthetic bootstrap completion evidence (pre-coverage gaps). |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/identity-failure/manifest.json | Proposed fixture manifest for identity-failure scenario. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/identity-failure/expected.json | Proposed expected workflow/finding output contract for identity-failure. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/identity-failure/evidence/client-identity/current/ClientIDManagerStartup.log | Synthetic identity terminal failure evidence. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/identity-failure/evidence/client-evaluation/current/CcmEval.log | Synthetic service evaluation success evidence (pre-identity failure). |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/identity-failure/evidence/client-ccmsetup/current/ccmsetup.log | Synthetic bootstrap completion evidence (pre-identity failure). |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/contradictory/manifest.json | Proposed fixture manifest for contradictory scenario (different bootstrap keys). |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/contradictory/expected.json | Proposed expected workflow/finding output contract for contradictory. |
| crates/cmtraceopen-parser/tests/fixtures/sccm/client/health/contradictory/evidence/client-ccmsetup/current/ccmsetup.log | Synthetic contradictory bootstrap failure+success evidence with distinct bootstrap IDs. |
18 tasks
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Owner
Author
|
@coderabbitai full review Please review current head |
|
✅ Action performedFull review finished. Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 2 minutes. |
adamgell
added a commit
that referenced
this pull request
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Issue-scoped synthetic health/location corpus preparation for #320:
LocationServices.logcapture with sorted membershipsThis PR adds no production reducer or speculative shared interface.
Dependency state
Production #320 implementation remains blocked on reviewed #318/#319 evidence and intake contracts. Workflows remain independent; health output is not required by policy/deployment/update reducers.
Verification
cargo test --locked -p cmtraceopen-parser— 571 passednpx tsc --noEmit— passRepo-wide formatting remains red only for inherited unrelated ESP/Tauri drift; this corpus slice changes no Rust source.
CodeRabbit and independent semantic review are requested. Native Windows acceptance is not claimed.
Refs #320
Refs #317