fix: include pending_organization_id in membership tier filters #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HAS_USER and HAS_ENGAGED_USER filters were only matching Slack users by email domain. However, Slack users are primarily associated with organizations via the pending_organization_id field (set during domain discovery). This caused Engaged and Registered counts to show 0. Changes: - Add pending_organization_id checks to HAS_USER filter - Add pending_organization_id checks to HAS_ENGAGED_USER filter - Add exclusion (pending_organization_id IS NULL) to email domain fallback to prevent double-counting - Update both regular and aliased filter versions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The v2.6-rc versioned docs have absolute links (/docs/...) that don't resolve correctly since the files are at v2.6-rc/docs/. This is a pre-existing issue with how versioned docs were synced. Exclude v2.6-rc from the broken links check until the versioning approach is fixed. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pending_organization_idfor Slack user associationsProblem
The membership metrics dashboard showed 0 Engaged and 0 Registered organizations because the
HAS_USERandHAS_ENGAGED_USERSQL filters were only matching Slack users by email domain. However, Slack users are primarily associated with organizations via thepending_organization_idfield (set during domain discovery), not email domain matching.Solution
Updated the filters to check for Slack users in three ways:
organization_memberships(site users)pending_organization_id(primary Slack association)pending_organization_id IS NULLto prevent overlap)Test plan
🤖 Generated with Claude Code