fix: Accept Authorization: Bearer header for MCP authentication #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCP clients like Anthropic only support the standard Authorization: Bearer header, not custom x-adcp-auth headers. This fix allows authentication via either header for compatibility with standard MCP clients. - x-adcp-auth header takes precedence when both are present (backwards compatible) - Bearer prefix matching is case-insensitive per RFC 6750 - Empty tokens after Bearer prefix are rejected - Added comprehensive test coverage Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Upgrade filelock 3.20.1→3.20.3 (GHSA-qmgc-5h2g-mvrw) - Upgrade urllib3 2.6.2→2.6.3 (GHSA-38jv-5279-wg99) - Upgrade Werkzeug 3.1.4→3.1.5 (GHSA-87hc-h4r5-73f7) - Fix test_media_buy_create_helpers.py to mock external HTTP calls instead of making real network requests to creative agent Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
BaiyuScope3
approved these changes
Jan 14, 2026
Collaborator
BaiyuScope3
left a comment
BaiyuScope3
left a comment
There was a problem hiding this comment.
E2E testing failing, but I'll leave a approve so we can merge it after it fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Authorization: Bearerheader, not customx-adcp-authheadersx-adcp-authheader takes precedence when both are present (backwards compatible)Changes
src/core/auth.pyto check forAuthorization: Beareras a fallback whenx-adcp-authis not presenttests/unit/test_auth_bearer_header.pyTest plan
uv run pytest tests/unit/test_auth_bearer_header.py)uv run pytest tests/unit/ -k "auth"- 153 passed)uvx adcpCLI toolNote
The pre-existing failure in
test_media_buy_create_helpers.py::TestGetFormatSpecSync::test_successful_format_retrievalis unrelated to this change - it also fails on main.🤖 Generated with Claude Code