fix: Sync custom targeting keys to adapter_config during inventory sync #956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Erin had issue when approving a media buy for GAM , error message
Event after the targeting key updated in the GAM IU, still showing the same error.
The root cause is below:
When clicking 'Sync Targeting Data' in the Targeting Browser:
gam_inventorytable (for UI display) ✅adapter_config.custom_targeting_keyscolumn is NOT updated ❌GAMTargetingManager.resolve_custom_targeting_key_id()which reads fromadapter_config.custom_targeting_keysSolution
After writing custom targeting keys to
gam_inventory, also updateadapter_config.custom_targeting_keyswith the key name → GAM ID mapping.Changes
_update_adapter_config_targeting_keys()method togam_inventory_service.pybackground_sync_service.pyafter writing targeting keys to databaseTesting
adapter_config.custom_targeting_keysshould now be populated