Pretty massive PR #7
Conversation
|
Seriously, if you're not comfortable merging all this, just close it. |
Put readComponents back into init.py
Bugfix: folded lines missing indentation
… the library didn't load behaviors unless the icalendar submodule was explicitly imported (this is still an issue with vcard, though. Tests break if we import vcard. Oups, that's very bad indeed)
…ed. That means we probably don't need the six.u method at all, so I removed it. bugfix 2: str(x) fails on python2 if x is a unicode object containing non-ascii characters. Created a function str_(x) that will use utf-8 as default encoding
|
@tBaxter This PR seems to do good things in python3. But I've noticed bad behaviours. Do you want me to write it here or to open an issue on your fork? |
|
I'd open an issue on the fork. There's been some changes since this. This PR should probably just be closed. It's messy anyway. |
|
I can't open an issue on the fork actually, for some reason. |
|
Interesting. Wonder why. Maybe because it's a fork? |
|
Yeah, I just tried, and options seems not to be available by default on forks. However, you can just check the Issues box in options :) |
|
ah. There it is! On Thu, May 7, 2015 at 1:57 PM, Nicolas Jeannerod notifications@github.com
|
Bugfixes: missing import of icalendar, python2 unicode support
Removed test_vobject
Python 3 timezone declaration fix
5 participants
But it includes:
Full Py3 Support
Extensive new tests
Travis CI
At this point, it's a pretty major rewrite of the original vobject code. Or, for that matter, this branch. Whether you wish to include it, or just consider my fork to be another branch or what is up to you. If you do, you'll want to squash merge :-)